Fix JSDoc @import crashes in getCompletionEntryDetails #62028
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The completion system was crashing when trying to get completion entry details for JSDoc
@import
statements. Consider:The error was:
Root Cause:
The completion system tries to promote type-only imports to regular imports when they are used in value contexts. For JSDoc
@import
statements, this promotion logic incorrectly assumed the import had atype
keyword that could be found and removed, but JSDoc imports don't have this structure - they are inherently type-only.Solution:
Added a check in
promoteImportClause
function to skip type keyword deletion for JSDoc imports:This allows JSDoc imports to be safely handled during the completion promotion process without attempting to remove a non-existent
type
keyword.Fixes #62027.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.